Skip to content

Refactor font package #251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 29, 2024
Merged

Refactor font package #251

merged 2 commits into from
Dec 29, 2024

Conversation

HeavyWombat
Copy link
Member

@HeavyWombat HeavyWombat commented Dec 29, 2024

Make command indicator string configurable.

Refactor font usage to have common interface.

Introduce environment variable to override default command indicator.
Create abstraction for a font to be used in termshot.
@HeavyWombat HeavyWombat changed the title refactor/font pkg Refactor font package Dec 29, 2024
Copy link

codecov bot commented Dec 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.00%. Comparing base (e0d5317) to head (4e18ec5).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #251   +/-   ##
=======================================
  Coverage   75.00%   75.00%           
=======================================
  Files           1        1           
  Lines         224      224           
=======================================
  Hits          168      168           
  Misses         50       50           
  Partials        6        6           
Flag Coverage Δ
unittests 75.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@HeavyWombat HeavyWombat merged commit 18aa501 into main Dec 29, 2024
8 checks passed
@HeavyWombat HeavyWombat deleted the refactor/font-pkg branch December 29, 2024 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant