sidekiq: disable update checker #1368
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is configured to look for upstream Mastodon updates, so it isn't actually doing anything useful for Hometown admins.
|
Thank you this is much appreciated! |
3b7c5f8
into
hometown-fork:v4.2.17+hometown-1.1.1
16 of 24 checks passed
|
Thanks for the very fast merge! |
|
Hi! I understand why you disabled this feature, but we've implemented it after noticing people took a long time to update when a security fix is released, and we have observed this feature was pretty effective at making server administrators update. |
|
The issue is that it's prompting Hometown users to upgrade to versions that don't exist. I'd like to reenable it for Hometown, but that would need a copy of the API service to point to that has relevant data. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is configured to look for upstream Mastodon updates, so it isn't actually doing anything useful for Hometown admins. Eventually it can be turned back on if there's a Hometown-specific API that returns the appropriate versions, but in the meantime this feature is misleading.
Looking at the sidekiq-scheduler docs, I think this should be enough to turn it off: https://github.com/sidekiq-scheduler/sidekiq-scheduler?tab=readme-ov-file#schedule-configuration
I also disabled it in the place where upstream Mastodon configures the feature to be on or off: https://docs.joinmastodon.org/admin/upgrading/#automated_checks
Fixes #1367.