Skip to content

Conversation

felipecrs
Copy link
Contributor

@felipecrs felipecrs commented Feb 2, 2023

Proposed change

Pending:

This allows add-ons to use CAP_BPF and CAP_PERFMON as privileged capabilities.

I intentionally left these two out of the math which decreases points of security if the add-on uses these features, but I'm happy to change if told to.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (which adds functionality to the supervisor)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast supervisor tests)
  • Tests have been added to verify that the new code works.

If API endpoints of add-on configuration are added/changed:

@github-actions
Copy link
Contributor

github-actions bot commented Mar 4, 2023

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days.
Thank you for your contributions.

@github-actions github-actions bot added the stale label Mar 4, 2023
@github-actions github-actions bot closed this Mar 11, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Mar 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

intel_gpu_top from within add-ons errors with Failed to initialize PMU! (Permission denied)
1 participant