Display full error for card preview mode #25747
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
MindFreeze
approved these changes
Jun 11, 2025
piitaya
added a commit
that referenced
this pull request
Jun 11, 2025
MindFreeze
pushed a commit
that referenced
this pull request
Jun 12, 2025
MindFreeze
pushed a commit
that referenced
this pull request
Jun 12, 2025
Assist Chat: handle intent progress delta not always being there (#25730) handle intent progress data type change More support for no-grid energy dashboard (#25644) * More support for no-grid energy dashboard * Update src/panels/lovelace/cards/energy/hui-energy-distribution-card.ts Co-authored-by: Petar Petrov <MindFreeze@users.noreply.github.com> * lint --------- Co-authored-by: Petar Petrov <MindFreeze@users.noreply.github.com> Z-Wave: apply sentence-style capitalization (#25739) Display full error for card preview mode (#25747) Fix edit card not working in chrome after editing (#25751) Change backup type order (#25759) Fix alerts refresh on device page (#25748) * Fix alerts refresh on device page * don't reset actions periodically * reset stuff only on deviceId change Ensure grid options always return an object (#25760)
MindFreeze
added a commit
that referenced
this pull request
Jun 23, 2025
* Handle ZWaveJS device delete in frontend according to status * finishing touches * Fix custom value selected when clicking item in combo box (#25734) * Assist Chat: handle intent progress delta not always being there (#25730) handle intent progress data type change * More support for no-grid energy dashboard (#25644) * More support for no-grid energy dashboard * Update src/panels/lovelace/cards/energy/hui-energy-distribution-card.ts Co-authored-by: Petar Petrov <MindFreeze@users.noreply.github.com> * lint --------- Co-authored-by: Petar Petrov <MindFreeze@users.noreply.github.com> * Z-Wave: apply sentence-style capitalization (#25739) * Display full error for card preview mode (#25747) * Fix edit card not working in chrome after editing (#25751) * Change backup type order (#25759) * Fix alerts refresh on device page (#25748) * Fix alerts refresh on device page * don't reset actions periodically * reset stuff only on deviceId change * Ensure grid options always return an object (#25760) Assist Chat: handle intent progress delta not always being there (#25730) handle intent progress data type change More support for no-grid energy dashboard (#25644) * More support for no-grid energy dashboard * Update src/panels/lovelace/cards/energy/hui-energy-distribution-card.ts Co-authored-by: Petar Petrov <MindFreeze@users.noreply.github.com> * lint --------- Co-authored-by: Petar Petrov <MindFreeze@users.noreply.github.com> Z-Wave: apply sentence-style capitalization (#25739) Display full error for card preview mode (#25747) Fix edit card not working in chrome after editing (#25751) Change backup type order (#25759) Fix alerts refresh on device page (#25748) * Fix alerts refresh on device page * don't reset actions periodically * reset stuff only on deviceId change Ensure grid options always return an object (#25760) * fix merge issue * lint * Update text and buttons * Update src/translations/en.json Co-authored-by: Norbert Rittel <norbert@rittel.de> * update text --------- Co-authored-by: Paul Bottein <paul.bottein@gmail.com> Co-authored-by: Paulus Schoutsen <balloob@gmail.com> Co-authored-by: karwosts <32912880+karwosts@users.noreply.github.com> Co-authored-by: c0ffeeca7 <38767475+c0ffeeca7@users.noreply.github.com> Co-authored-by: Norbert Rittel <norbert@rittel.de>
MindFreeze
reviewed
Jun 23, 2025
| @@ -200,6 +222,7 @@ export class HuiCard extends ReactiveElement { | |||
| this._element.preview = this.preview; | |||
| // For backwards compatibility | |||
| (this._element as any).editMode = this.preview; | |||
| fireEvent(this, "card-updated"); | |||
There was a problem hiding this comment.
@piitaya could this be causing home-assistant/core#146799 ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Display full error in the error card when going to edit mode.
Quick fix for #25613
For now we have 2 types of errors :
I first tried to merge them but it was not possible because in many cases, errors were duplicated.
So I prefer to keep the previous behavior.
We should think about a better error management for error card and provide API for built-in card and custom card to provide different types of errors :
Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: