Skip to content

Conversation

wendevlin
Copy link
Contributor

Proposed change

  • remove static roboto font from ha-badge to make it themeable

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@wendevlin wendevlin added this to the 2024.12 milestone Dec 3, 2024
@piitaya piitaya enabled auto-merge (squash) December 3, 2024 14:09
@piitaya piitaya merged commit 480de9e into dev Dec 3, 2024
12 checks passed
@piitaya piitaya deleted the badge-remove-static-font branch December 3, 2024 14:16
bramkragten pushed a commit that referenced this pull request Dec 4, 2024
@bramkragten bramkragten mentioned this pull request Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Badges font-family is hard coded to Roboto instead of theme variable
3 participants