Update aiohttp to version 3.4.0. #16198
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
On Fedora 29 aiohttp-3.4.0 leads to a build error because of the changes around nodejs/http-parser. creating build/temp.linux-x86_64-3.7/vendor/http-parser
gcc -pthread -DDYNAMIC_ANNOTATIONS_ENABLED=1 -DNDEBUG -O2 -g -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -fexceptions -fstack-protector-strong -grecord-gcc-switches -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -m64 -mtune=generic -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection -D_GNU_SOURCE -fPIC -fwrapv -O2 -g -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -fexceptions -fstack-protector-strong -grecord-gcc-switches -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -m64 -mtune=generic -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection -fPIC -DHTTP_PARSER_STRICT=0 -I/usr/include/python3.7m -c aiohttp/_http_parser.c -o build/temp.linux-x86_64-3.7/aiohttp/_http_parser.o
aiohttp/_http_parser.c:590:10: fatal error: ../vendor/http-parser/http_parser.h: No such file or directory
#include "../vendor/http-parser/http_parser.h"
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
error: command 'gcc' failed with exit status 1No sure how this affects the PyPI package. |
|
@fabaff http-parser is a git submodule, so make sure you have submodules initialized, like as described in the linked aiohttp issue. |
|
@Swamp-Ig great find on the TCP issue. Will have it included in 0.77 |
balloob
pushed a commit
that referenced
this pull request
Aug 26, 2018
Merged
girlpunk
pushed a commit
to girlpunk/home-assistant
that referenced
this pull request
Sep 4, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Update to aiohttp version 3.4.0
Related issue (if applicable): fixes aio-libs/aiohttp#3208
Why this is important
I discovered this problem when interacting with a device I'm aiming on integrating.
The aiohttp client, which in turn relies on nodejs/http-parser, messes up the TCP ACK packets and results in a bunch of TCP errors after sending a HTTP message when the header is split between TCP packets.
This might not always be visible, however it does result in a bunch of extra network traffic. In my particular case it was visible because the device didn't change states if the TCP connection didn't close properly (which seems to be a bug to me, but anyhow).
Checklist:
tox. Your PR cannot be merged unless tests pass