Skip to content

Conversation

cdce8p
Copy link
Member

@cdce8p cdce8p commented Jun 13, 2025

Proposed change

Alternative to #146728. This ignores the pycares shutdown thread during cleanup.

ERROR tests/components/spotify/test_media_player.py::test_entities - AssertionError: assert (False or False)
 +  where False = isinstance(<Thread(Thread-514 (_run_safe_shutdown_loop), started daemon 139957482026688)>, <class 'threading._DummyThread'>)
 +    where <class 'threading._DummyThread'> = threading._DummyThread
 +  and   False = <built-in method startswith of str object at 0x7f4a70226060>('waitpid-')
 +    where <built-in method startswith of str object at 0x7f4a70226060> = 'Thread-514 (_run_safe_shutdown_loop)'.startswith
 +      where 'Thread-514 (_run_safe_shutdown_loop)' = <Thread(Thread-514 (_run_safe_shutdown_loop), started daemon 139957482026688)>.name
ERROR tests/components/telegram_bot/test_telegram_bot.py::test_webhook_endpoint_generates_telegram_text_event - AssertionError: assert (False or False)
 +  where False = isinstance(<Thread(Thread-2019 (_run_safe_shutdown_loop), started daemon 140549231208128)>, <class 'threading._DummyThread'>)
 +    where <class 'threading._DummyThread'> = threading._DummyThread
 +  and   False = <built-in method startswith of str object at 0x7fd4308d8210>('waitpid-')
 +    where <built-in method startswith of str object at 0x7fd4308d8210> = 'Thread-2019 (_run_safe_shutdown_loop)'.startswith
 +      where 'Thread-2019 (_run_safe_shutdown_loop)' = <Thread(Thread-2019 (_run_safe_shutdown_loop), started daemon 140549231208128)>.name

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to developer documentation pull request:
  • Link to frontend pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@cdce8p cdce8p requested a review from bdraco June 13, 2025 13:04
@cdce8p cdce8p mentioned this pull request Jun 13, 2025
19 tasks
@bdraco bdraco added this to the 2025.6.1 milestone Jun 13, 2025
@cdce8p
Copy link
Member Author

cdce8p commented Jun 13, 2025

Verified it on my own fork. The CI run here will always succeed since it still uses the old pycares version. Merging it early to unblock CI for other PRs.

@cdce8p cdce8p merged commit 10874af into home-assistant:dev Jun 13, 2025
32 checks passed
@cdce8p cdce8p deleted the ignore-pycares-thread branch June 13, 2025 13:09
@frenck frenck mentioned this pull request Jun 13, 2025
wbyoung added a commit to wbyoung/movement that referenced this pull request Jun 14, 2025
This is required to prevent a current testing error.

See also: home-assistant/core#146733
wbyoung added a commit to wbyoung/watersmart that referenced this pull request Jun 14, 2025
This is required to prevent a current testing error.

See also: home-assistant/core#146733
wbyoung added a commit to tube0013/Smartcar-HA that referenced this pull request Jun 14, 2025
This is required to prevent a current testing error.

See also: home-assistant/core#146733
@github-actions github-actions bot locked and limited conversation to collaborators Jun 14, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants