Skip to content

Conversation

cdce8p
Copy link
Member

@cdce8p cdce8p commented Jun 13, 2025

Proposed change

CI runs without cache started failing after the release of pycares 4.9.0. Likely related to the new shutdown logic added in saghul/pycares#236. Add a temporary pin to fix failing CI runs.

ERROR tests/components/spotify/test_media_player.py::test_entities - AssertionError: assert (False or False)
 +  where False = isinstance(<Thread(Thread-514 (_run_safe_shutdown_loop), started daemon 139957482026688)>, <class 'threading._DummyThread'>)
 +    where <class 'threading._DummyThread'> = threading._DummyThread
 +  and   False = <built-in method startswith of str object at 0x7f4a70226060>('waitpid-')
 +    where <built-in method startswith of str object at 0x7f4a70226060> = 'Thread-514 (_run_safe_shutdown_loop)'.startswith
 +      where 'Thread-514 (_run_safe_shutdown_loop)' = <Thread(Thread-514 (_run_safe_shutdown_loop), started daemon 139957482026688)>.name
ERROR tests/components/telegram_bot/test_telegram_bot.py::test_webhook_endpoint_generates_telegram_text_event - AssertionError: assert (False or False)
 +  where False = isinstance(<Thread(Thread-2019 (_run_safe_shutdown_loop), started daemon 140549231208128)>, <class 'threading._DummyThread'>)
 +    where <class 'threading._DummyThread'> = threading._DummyThread
 +  and   False = <built-in method startswith of str object at 0x7fd4308d8210>('waitpid-')
 +    where <built-in method startswith of str object at 0x7fd4308d8210> = 'Thread-2019 (_run_safe_shutdown_loop)'.startswith
 +      where 'Thread-2019 (_run_safe_shutdown_loop)' = <Thread(Thread-2019 (_run_safe_shutdown_loop), started daemon 140549231208128)>.name

/CC @bdraco

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to developer documentation pull request:
  • Link to frontend pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@cdce8p cdce8p requested a review from a team as a code owner June 13, 2025 12:15
@cdce8p cdce8p added this to the 2025.6.1 milestone Jun 13, 2025
@bdraco bdraco marked this pull request as draft June 13, 2025 12:36
@bdraco
Copy link
Member

bdraco commented Jun 13, 2025

We need to fix the CI instead

Copy link
Contributor

@chemelli74 chemelli74 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx !

@cdce8p cdce8p removed this from the 2025.6.1 milestone Jun 13, 2025
@cdce8p
Copy link
Member Author

cdce8p commented Jun 13, 2025

Closing it in favor of #146733.

@cdce8p cdce8p closed this Jun 13, 2025
@cdce8p cdce8p deleted the pin-pycares branch June 13, 2025 13:05
@github-actions github-actions bot locked and limited conversation to collaborators Jun 14, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants