Skip to content

Fix throttling issue in HomematicIP Cloud #146683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jun 13, 2025

Conversation

hahn-th
Copy link
Contributor

@hahn-th hahn-th commented Jun 12, 2025

Proposed change

Fix a bug which causes many get-state requests which get blocked by HomematicIP

Changelog: https://github.com/hahn-th/homematicip-rest-api/blob/master/CHANGELOG.md
Full diff: hahn-th/homematicip-rest-api@2.0.4...2.0.5

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes Homematic IP Throtteling Rest active #146618
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to developer documentation pull request:
  • Link to frontend pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@joostlek joostlek added this to the 2025.6.1 milestone Jun 12, 2025
@merschformann
Copy link

Thanks @hahn-th for the fast response / work on this! 🤗 ❤️

Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for bumping the dependency! However, could you please update the PR description to contain at least one (or multiple) of the following:

  • A link to the release notes of this package version, and all versions in between.
  • A link to the changelog of this package.
  • A link to a Git(Hub) diff/compare view from the current version to the bumped version.

This allows us to review upstream changes, which is needed to decide this change is working as intended and/or if we can include it in, for example, a patch release of Home Assistant.

Thanks already! 👍

@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot marked this pull request as draft June 13, 2025 16:46
@frenck frenck modified the milestones: 2025.6.1, 2025.6.2 Jun 13, 2025
@hahn-th
Copy link
Contributor Author

hahn-th commented Jun 13, 2025

Thanks for bumping the dependency! However, could you please update the PR description to contain at least one (or multiple) of the following:

  • A link to the release notes of this package version, and all versions in between.
  • A link to the changelog of this package.
  • A link to a Git(Hub) diff/compare view from the current version to the bumped version.

This allows us to review upstream changes, which is needed to decide this change is working as intended and/or if we can include it in, for example, a patch release of Home Assistant.

Thanks already! 👍

Sorry 🙈 Forgot that this morning.

@hahn-th hahn-th marked this pull request as ready for review June 13, 2025 17:26
@home-assistant home-assistant bot requested a review from frenck June 13, 2025 17:26
@frenck frenck modified the milestones: 2025.6.2, 2025.6.1 Jun 13, 2025
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @hahn-th 👍

../Frenck

@frenck frenck merged commit 761a087 into home-assistant:dev Jun 13, 2025
48 checks passed
frenck pushed a commit that referenced this pull request Jun 13, 2025
Co-authored-by: J. Nick Koston <nick@koston.org>
@frenck frenck mentioned this pull request Jun 13, 2025
@Sebiggestboss
Copy link

@hahn-th - Thank you so much for fixing this so fast!!!

@github-actions github-actions bot locked and limited conversation to collaborators Jun 15, 2025
@hahn-th hahn-th deleted the fix-throttling branch July 15, 2025 18:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Homematic IP Throtteling Rest active
6 participants