-
-
Notifications
You must be signed in to change notification settings - Fork 34.8k
Bump wakeonlan to 3.1.0 #146655
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump wakeonlan to 3.1.0 #146655
Conversation
Hey there @ntilley905, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
Hey there @chemelli74, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !
Co-authored-by: J. Nick Koston <nick@koston.org>
Proposed change
See #146654
It seems some custom integrations (or maybe some transitive dependencies) have started to use a later version of wakeonlan, and it is causing issuesssh-terminal-manager
has a pin to"wakeonlan >= 3.0.0"
, and therefore custom integration https://github.com/zhbjsh/homeassistant-ssh cannot be installed at the same time aswake_on_lan
orsamsungtv
integration.I don't usually think we should change core integrations to fix custom integration issues, but in this case I think it makes sense to bump
pywakeonlan
to the latest.remcohaszing/pywakeonlan@2.1.0...3.1.0
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
.To help with the load of incoming pull requests: