Skip to content

Conversation

aethrvmn
Copy link
Contributor

@aethrvmn aethrvmn commented Jun 12, 2025

Proposed change

RSA has been deprecated for use of ssharuba.

This fixes it by removing the rsa requirement in thessh command.

Tested locally and working.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Code quality improvements to existing code or addition of tests
  • Breaking change (fix/feature causing existing functionality to break)

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

RSA has been deprecated for use of ssh`aruba`. 

This fixes it by removing the `rsa` requirement in the`ssh` command.

Tested locally and working.
Copy link

@home-assistant home-assistant bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @aethrvmn

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@home-assistant home-assistant bot marked this pull request as draft June 12, 2025 08:53
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@aethrvmn aethrvmn marked this pull request as ready for review June 12, 2025 09:00
@home-assistant home-assistant bot dismissed their stale review June 12, 2025 09:01

Stale

@epenet epenet changed the title Update device_tracker.py Drop rsa requirement in aruba Jun 12, 2025
@epenet epenet changed the title Drop rsa requirement in aruba Drop HostKeyAlgorithms in aruba Jun 12, 2025
@epenet epenet added this to the 2025.6.1 milestone Jun 12, 2025
Copy link
Contributor

@epenet epenet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@frenck frenck merged commit 1a5bc2c into home-assistant:dev Jun 13, 2025
29 checks passed
frenck pushed a commit that referenced this pull request Jun 13, 2025
@frenck frenck mentioned this pull request Jun 13, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Jun 14, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Aruba device integration problem
3 participants