Skip to content

Conversation

epenet
Copy link
Contributor

@epenet epenet commented Sep 20, 2022

Proposed change

Use SensorEntityDescription in kostal plenticore

Needs:

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link

Hey there @stegm, mind taking a look at this pull request as it has been labeled with an integration (kostal_plenticore) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@epenet epenet changed the title Kostal-plenticore-sensor Use SensorEntityDescription in kostal plenticore Sep 20, 2022
@epenet epenet mentioned this pull request Sep 20, 2022
26 tasks
@epenet epenet force-pushed the kostal-plenticore-sensor branch from ad338f9 to ad1efb0 Compare September 20, 2022 20:17
@epenet epenet marked this pull request as ready for review September 20, 2022 20:19
Comment on lines +48 to +51
@dataclass
class PlenticoreSensorEntityDescription(
SensorEntityDescription, PlenticoreRequiredKeysMixin
):
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this PR, I am only converting the tuples to SensorEntityDescription.
The old process data id is mapped to key, and entity name suffix is mapped to name in the standard EntityDescription.

Passing the EntityDescription to PlenticoreDataSensor will be done in a follow-up PR.

@MartinHjelmare MartinHjelmare merged commit bc120e9 into home-assistant:dev Sep 21, 2022
@epenet epenet deleted the kostal-plenticore-sensor branch September 21, 2022 09:21
@github-actions github-actions bot locked and limited conversation to collaborators Sep 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants