Add logic to open settings window next to main window #204
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
c12i
approved these changes
Aug 21, 2024
| const mainWindow = PRIVILEDGED_LAUNCHER_WINDOWS[MAIN_WINDOW]; | ||
| const [xMain, yMain] = mainWindow.getPosition(); | ||
| const settingsWindow = PRIVILEDGED_LAUNCHER_WINDOWS[SETTINGS_WINDOW]; | ||
| if (!settingsWindow) throw new Error('Settings window is undefined.'); |
There was a problem hiding this comment.
Interesting, the settingsWindow remains undefined until the show method is called right?
There was a problem hiding this comment.
No, it should already be defined here as it is being created as part of the setupAppWindows function (in this PR again, this was not the case in #201) .
There was a problem hiding this comment.
.show() only makes it be visible and come to front on the screen. The BrowserWindow javascript object is already defined before that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #201