Skip to content

New window open logic #201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

New window open logic #201

wants to merge 4 commits into from

Conversation

matthme
Copy link
Contributor

@matthme matthme commented Aug 15, 2024

This PR changes the logic around creating/opening/showing windows in the following way:

  • the settings window is created independently from the main window
  • if the settings window is opened from the main window, it will always show next to the main window, i.e. on the same screen
  • the CommandOrControl+Shift+L shortcut now also closes the main window if the main window is already focused

@matthme matthme requested a review from c12i August 15, 2024 15:11
@matthme matthme mentioned this pull request Aug 15, 2024
Open
16 tasks
@matthme matthme mentioned this pull request Aug 21, 2024
Merged
@matthme matthme closed this Aug 21, 2024
@matthme
Copy link
Contributor Author

matthme commented Aug 21, 2024

replaced by #204

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c12i c12i Awaiting requested review from c12i

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@matthme