Skip to content

Add Open/Export logs button to error message #200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 19, 2024
Merged

Add Open/Export logs button to error message #200

merged 2 commits into from
Aug 19, 2024

Conversation

matthme
Copy link
Contributor

@matthme matthme commented Aug 15, 2024

This PR

  • adds an Open Logs and an Export Logs button to the error dialog when holochain fails to start up
  • converts the "wrong password" error to a toast instead of a dialog

@matthme matthme requested review from snowshiva and c12i August 15, 2024 13:45
@matthme matthme mentioned this pull request Aug 15, 2024
Open
16 tasks
snowshiva
snowshiva approved these changes Aug 19, 2024
View reviewed changes
Copy link
Contributor

@snowshiva snowshiva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@matthme matthme merged commit 9198830 into develop Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c12i c12i Awaiting requested review from c12i

1 more reviewer

@snowshiva snowshiva snowshiva approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matthme @snowshiva