Skip to content

Don't use setuptools_scm if .git does not exists #885

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 8, 2023
Merged

Don't use setuptools_scm if .git does not exists #885

merged 2 commits into from
Nov 8, 2023

Conversation

hoxbro
Copy link
Member

@hoxbro hoxbro commented Nov 7, 2023

I noticed setuptools_scm took too long to load:

python -X importtime -c "import param" 2> log.txt && tuna log.txt

image

@hoxbro hoxbro requested a review from maximlt November 7, 2023 16:36
jbednar
jbednar approved these changes Nov 8, 2023
View reviewed changes
Copy link
Member

@jbednar jbednar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks useful, thanks!

@maximlt maximlt merged commit b4b9c1c into main Nov 8, 2023
@maximlt maximlt deleted the param_setuptools_scm branch November 8, 2023 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbednar jbednar jbednar approved these changes

@maximlt maximlt Awaiting requested review from maximlt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hoxbro @jbednar @maximlt