Skip to content

Fix implementation of rx.__iter__ #846

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 25, 2023
Merged

Fix implementation of rx.__iter__ #846

merged 2 commits into from
Sep 25, 2023

Conversation

philippjfr
Copy link
Member

The previous implementation was trying to be too clever. This implementation is simpler but achieves the same thing.

hoxbro
hoxbro reviewed Sep 25, 2023
View reviewed changes
@philippjfr philippjfr merged commit 9b7382c into main Sep 25, 2023
@philippjfr philippjfr deleted the rx_iterator branch September 25, 2023 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hoxbro hoxbro hoxbro left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@philippjfr @hoxbro