Validate the type of bounds and softbounds attributes for Range parameter types
#824
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philippjfr
approved these changes
Aug 28, 2023
jbednar
reviewed
Aug 28, 2023
| if sv is None: | ||
| continue | ||
| self._validate_bound_type(sv, spos, 'softbound') | ||
|
|
There was a problem hiding this comment.
If you're changing the signature of this already, why not just change it to accept a bounds obj and a description, so that this code isn't duplicated? That way some future change to one of the code paths won't be missed on the other one.
There was a problem hiding this comment.
Refactored in 4a810ac, I'll let you merge if you're okay with the change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #660