Skip to content

master to main #672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 29, 2022
Merged

master to main #672

merged 2 commits into from
Dec 29, 2022

Conversation

maximlt
Copy link
Member

@maximlt maximlt commented Dec 29, 2022

No description provided.

@maximlt
Copy link
Member Author

maximlt commented Dec 29, 2022

@jlstevens param.version has a reference to master. Does it need to be updated to also try main?

param/param/version.py

Line 403 in 897687f

# Assuming the tag is a version if it isn't empty, 'master' and has a dot in it

@jlstevens
Copy link
Contributor

@jlstevens param.version has a reference to master. Does it need to be updated to also try main?

param/param/version.py

Line 403 in 897687f

# Assuming the tag is a version if it isn't empty, 'master' and has a dot in it

Yes. I think it should be sufficient to just add 'main' to that list.

@maximlt maximlt merged commit 10fff77 into main Dec 29, 2022
@maximlt maximlt deleted the master_to_main branch December 29, 2022 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maximlt @jlstevens