enh(bokeh): Add radius and radius_dimension to PointPlot
#6599
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6599 +/- ##
=======================================
Coverage 88.81% 88.82%
=======================================
Files 326 326
Lines 69530 69550 +20
=======================================
+ Hits 61756 61776 +20
Misses 7774 7774 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
hoxbro
commented
Jun 3, 2025
| def _init_glyph(self, plot, mapping, properties): | ||
| if "radius" in properties: | ||
| self._plot_methods = dict(single='circle', batched='circle') | ||
| properties.pop("size", None) |
There was a problem hiding this comment.
This will make it so radius always has priority over size.
radius and radius_dimension to PointPlotradius and radius_dimension to PointPlot
philippjfr
approved these changes
Jun 4, 2025
|
Looks good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
radiusandradius_dimensionto the Bokeh PointPlot. Because radius works with Circle, we update the_plot_methodsbefore calling_init_glyph.