Add MultiAxisTap stream #6374
Merged
Add MultiAxisTap stream #6374
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6374 +/- ##
==========================================
- Coverage 88.50% 88.49% -0.01%
==========================================
Files 323 323
Lines 68194 68265 +71
==========================================
+ Hits 60355 60412 +57
- Misses 7839 7853 +14 ☔ View full report in Codecov by Sentry. |
philippjfr
commented
Sep 17, 2024
hoxbro
reviewed
Sep 17, 2024
hoxbro
approved these changes
Sep 18, 2024
hoxbro
pushed a commit
that referenced
this pull request
Sep 23, 2024
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Retrofitting the existing
Tapstream with support for multiple axis was too awkward. This PR instead implements aMultiAxisTapstream which providesxsandysparameters giving you the tap locations indexed by the name of the dimension.