Skip to content

Vendor version.py to avoid relying on Param #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 1, 2022
Merged

Conversation

maximlt
Copy link
Member

@maximlt maximlt commented May 30, 2022

Param was just used as a build dependency for its version.py module (autover). Colorcet can just vendor version.py.

@codecov-commenter
Copy link

codecov-commenter commented May 30, 2022

Codecov Report

Attention: Patch coverage is 38.87240% with 206 lines in your changes missing coverage. Please review.

Project coverage is 85.78%. Comparing base (b1c7c1f) to head (e904ce5).

Files with missing lines Patch % Lines
colorcet/version.py 38.50% 206 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (b1c7c1f) and HEAD (e904ce5). Click for more details.

HEAD has 136 uploads less than BASE
Flag BASE (b1c7c1f) HEAD (e904ce5)
151 15
Additional details and impacted files
@@             Coverage Diff             @@
##           master      #84       +/-   ##
===========================================
- Coverage   95.82%   85.78%   -10.04%     
===========================================
  Files           7        8        +1     
  Lines        1579     1914      +335     
===========================================
+ Hits         1513     1642      +129     
- Misses         66      272      +206     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sophiamyang sophiamyang assigned sophiamyang and jbednar and unassigned sophiamyang Aug 1, 2022
@sophiamyang sophiamyang merged commit 3cdbb67 into master Aug 1, 2022
@sophiamyang sophiamyang deleted the param-lectomy branch August 1, 2022 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants