Build fails with Go 1.23 because of changed testing.testDeps #391
Description
When trying to build with Go 1.23 rc1 in
It failed at
hof/script/runtime/exe_next.go
Line 52 in bebc58f
with error:
# github.com/hofstadter-io/hof/script/runtime
script/runtime/exe_next.go:52:26: cannot use nopTestDeps{} (value of type nopTestDeps) as testing.testDeps value in argument to testing.MainStart: nopTestDeps does not implement testing.testDeps (missing method InitRuntimeCoverage)
InitRuntimeCoverage was added by @rsc in:
golang/go@180ea45#diff-36f401ff1ffadb7d7a39cf41c2329615b159fa95cf2e14c1f58d8c46331af429R208
See
- cmd/link: lock down future uses of linkname golang/go#67401
- https://tip.golang.org/doc/go1.23#linker
- https://github.com/golang/go/blob/82c14346d89ec0eeca114f9ca0e88516b2cda454/src/testing/internal/testdeps/deps.go#L218-L223
Given the NOP nature of nopTestDeps a possible workaround could be to just implement a dummy/nop function InitRuntimeCoverage() in the nopTestDeps:
func (nopTestDeps) InitRuntimeCoverage() (mode string, tearDown func(string, string) (string, error), snapcov func() float64) {
return
}