Migrate remaining block ciphers #369
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charego
commented
Oct 10, 2017
| public static Factory BlowfishCTR() { | ||
| return new Factory(8, 256, "blowfish-ctr", "Blowfish", COUNTER_MODE); | ||
| } | ||
| public static Factory BlowfishCBC() { | ||
| return new Factory(8, 128, "blowfish-cbc", "Blowfish", CIPHER_BLOCK_CHAINING_MODE); |
There was a problem hiding this comment.
Should this be increased to 256 to match BlowfishCTR?
The value from BlowfishCBC.java was 16, which I multiplied by 8 (like the rest).
There was a problem hiding this comment.
Yes, I think this should be the same as the BlowfishCTR
hierynomus
requested changes
Oct 11, 2017
| public static Factory BlowfishCTR() { | ||
| return new Factory(8, 256, "blowfish-ctr", "Blowfish", COUNTER_MODE); | ||
| } | ||
| public static Factory BlowfishCBC() { | ||
| return new Factory(8, 128, "blowfish-cbc", "Blowfish", CIPHER_BLOCK_CHAINING_MODE); |
There was a problem hiding this comment.
Yes, I think this should be the same as the BlowfishCTR
Repository owner
deleted a comment
Oct 11, 2017
hierynomus
requested changes
Oct 11, 2017
| public static Factory BlowfishCTR() { | ||
| return new Factory(8, 256, "blowfish-ctr", "Blowfish", COUNTER_MODE); | ||
| } | ||
| public static Factory BlowfishCBC() { | ||
| return new Factory(8, 256, "blowfish-cbc", "Blowfish", CIPHER_BLOCK_CHAINING_MODE); |
There was a problem hiding this comment.
Oops, seems I was wrong:
(From: https://www.ietf.org/rfc/rfc4344.txt)
The "blowfish-ctr" method uses Blowfish with 256-bit keys [SCHNEIER].
The block size is 8 bytes. (Note that "blowfish-cbc" from [RFC4253]
uses 128-bit keys.)
So revert that commit... Sorry :)
Repository owner
deleted a comment
Oct 11, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.