feat(widget): Suppress right-click event propagation #160
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JupyterLab captures right-click ("contextmenu") events globally, causing
conflicts with HiGlass's custom context menus when interacting with
anywidget.
This update introduces an `addEventListenersTo` function that prevents
"contextmenu" events from propagating beyond the widget bounds.
Additional event types can be easily added to this function in the
future if needed.
pkerpedjiev
approved these changes
Jan 23, 2025
pkerpedjiev
approved these changes
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JupyterLab captures right-click ("contextmenu") events globally, causing
conflicts with HiGlass's custom context menus when interacting with
anywidget.
This update introduces an
addEventListenersTofunction that prevents"contextmenu" events from propagating beyond the widget bounds.
Additional event types can be easily added to this function in the
future if needed.
Screen.Recording.2025-01-22.at.18.55.58.mov
Checklist