Skip to content
This repository was archived by the owner on Jul 22, 2020. It is now read-only.

Conversation

hhandoko
Copy link
Owner

@hhandoko hhandoko commented Feb 2, 2017

Summary

Fixes issue #30

This bug was a compound result of several different issues.

  • Existing API integration test produce a false positive since getVersion() property accessor never matches the condition (and thus skipping the assertion). Before it was matching MigrationVersion with String.
  • Once the match has been fixed, existing assertions were throwing errors since recent commits had updated some of the assertion check values (e.g. column values), and create or drop tables had been introduced.

Pull Request (PR) Checklist

Documentation

  • Documentation in README.md or Wiki updated

Code Review

  • Self code review -- take another pass through the changes yourself
  • Completed all relevant TODOs, or call them out in the PR comments

Tests

  • All tests passes

@hhandoko hhandoko added the task label Feb 2, 2017
@hhandoko hhandoko added this to the cassandra-migration-0.11 milestone Feb 2, 2017
@hhandoko hhandoko merged commit 2031739 into master Feb 2, 2017
@hhandoko hhandoko deleted the bug/issue_30_empty_resultset_in_kotlin_it branch February 2, 2017 06:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant