Skip to content
This repository was archived by the owner on Jul 22, 2020. It is now read-only.

Chore - Convert SchemaVersionDAO to Kotlin code #44

Merged
merged 2 commits into from
Feb 2, 2017
Merged

Chore - Convert SchemaVersionDAO to Kotlin code #44

merged 2 commits into from
Feb 2, 2017

Conversation

hhandoko
Copy link
Owner

@hhandoko hhandoko commented Feb 2, 2017 •
edited
Loading

Summary

Completes chore #39

SchemaVersionDAO converted into Kotlin code. Note that there are still refactoring pending (marked as TODO). Mainly:

  • Need to split the table access / mapping into either internal object or separate static object.
  • Need to refactor collection methods into idiomatic Kotlin.

Pull Request (PR) Checklist

Documentation

  • Documentation in README.md or Wiki updated

Code Review

  • Self code review -- take another pass through the changes yourself
  • Completed all relevant TODOs, or call them out in the PR comments

Tests

  • All tests passes

@hhandoko hhandoko added the task label Feb 2, 2017
@hhandoko hhandoko added this to the cassandra-migration-0.11 milestone Feb 2, 2017
@hhandoko hhandoko merged commit faa3f9f into master Feb 2, 2017
@hhandoko hhandoko deleted the chore/schema_version_dao_to_kotlin branch February 2, 2017 05:29
@hhandoko hhandoko mentioned this pull request Feb 2, 2017
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
task
Projects
None yet
Milestone
cassandra-migration-0.11
Development

Successfully merging this pull request may close these issues.
1 participant
@hhandoko