Skip to content

Conversation

tjain-mcc
Copy link
Contributor

@tjain-mcc tjain-mcc commented Jan 27, 2022

@mfalkvidd
Copy link

@tjain-mcc woud you mind renaming the file to .md so github can render it?

@jamiew
Copy link
Contributor

jamiew commented Jan 27, 2022

.md added, will be reviewing remainder this morning

@philltran
Copy link

Thanks for the well thought out and written HIP.

Should HIP52 be referencing HIP51 as opposed to HIP50 such as here?

Also the filename of this HIP should be changed to 0052-lorawan-dao.md

I am not sure the protocol here, should I submit a PR to tjain-mcc or will this comment suffice?

@hiptron hiptron added the draft label Jan 27, 2022
@jamiew
Copy link
Contributor

jamiew commented Jan 27, 2022

@philltran thanks for flagging, I went ahead and fixed those

There are a couple other fixes needed but I think this is sufficient to merge for discussion and can be corrected in another PR. I'm sure there will be others

@hiptron hiptron mentioned this pull request Jan 27, 2022
@jamiew jamiew merged commit 8c1bffe into helium:master Jan 27, 2022
@jamiew
Copy link
Contributor

jamiew commented Jan 27, 2022

This HIP draft has been numbered and merged for discussion as HIP 51.

Please direct future questions & comments to the new tracking issue: #338

If you are one of the named authors, please include #338 in future pull requests to have them automatically merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants