Skip to content

Set DisableCompression to true to disable unwanted httpclient transfo… #8070

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 8, 2020
Merged

Set DisableCompression to true to disable unwanted httpclient transfo… #8070

merged 1 commit into from
May 8, 2020

Conversation

Idane
Copy link
Contributor

@Idane Idane commented May 7, 2020 •
edited
Loading

What this PR does / why we need it:
Ports the fix made in #4165 and fixes #2916

If applicable:

  • this PR contains documentation
  • this PR contains unit tests
  • this PR has been tested for backwards compatibility

@helm-bot helm-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 7, 2020
@Idane
Set DisableCompression to true to disable unwanted httpclient transfo…
93b0eee 
…rmation

Signed-off-by: Idan Elhalwani <idan@elhalwani.com>
@Idane Idane force-pushed the feature/port4165 branch from 46ee1c8 to 93b0eee Compare May 7, 2020 09:38
@mattfarina
Copy link
Collaborator

I've duplicated the issue where the fix was merged into Helm v2.

@mattfarina mattfarina added bug Categorizes issue or PR as related to a bug. v3.x Issues and Pull Requests related to the major version v3 labels May 8, 2020
@mattfarina mattfarina added this to the 3.2.2 milestone May 8, 2020
@mattfarina mattfarina self-requested a review May 8, 2020 18:20
mattfarina
mattfarina approved these changes May 8, 2020
View reviewed changes
Copy link
Collaborator

@mattfarina mattfarina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and it fixes the issue. I used the same method that @bacongobbler used when testing the change to Helm v2.

@mattfarina mattfarina added the needs-pick Indicates that a PR needs to be cherry-picked into the next release candidate. label May 8, 2020
@mattfarina mattfarina merged commit af52d35 into helm:master May 8, 2020
@liuming-dev
Copy link
Contributor

Need to perform gofmt -l -w -s . to format code.

@mattfarina mattfarina added the picked Indicates that a PR has been cherry-picked into the next release candidate. label Jun 4, 2020
@carrodher carrodher mentioned this pull request Jun 3, 2022
Closed
@carrodher carrodher mentioned this pull request Jun 21, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattfarina mattfarina mattfarina approved these changes

Assignees
No one assigned
Labels
bug Categorizes issue or PR as related to a bug. needs-pick Indicates that a PR needs to be cherry-picked into the next release candidate. picked Indicates that a PR has been cherry-picked into the next release candidate. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. v3.x Issues and Pull Requests related to the major version v3
Projects
None yet
Milestone
3.2.2
Development

Successfully merging this pull request may close these issues.

gzip: invalid header
4 participants
@Idane @mattfarina @liuming-dev @helm-bot