fix(helm): Use burst limit setting for discovery #13129
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When --burst-limit/$HELM_BURST_LIMIT is set, the specified value is not currently used for the discovery client instantiated by genericclioptions. This change sets genericclioptions.discoveryBurst to the value of --burst-limit, meaning it should now be possible to fix client-side throttling issues encountered by the discovery client. This value is only configured if --burst-limit is actually set. If --burst-limit is set to the default value, then discoveryBurst should be left at its default of 300. Closes helm#13128 Signed-off-by: Evan Foster <efoster@adobe.com>
Starblade42
approved these changes
Jun 19, 2024
mattfarina
approved these changes
Jun 20, 2024
|
XS sized changes only need one maintainer approval to merge. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
--burst-limit/$HELM_BURST_LIMITis set, the specified value is not currently used for the discovery client instantiated bygenericclioptions. This change setsgenericclioptions.discoveryBurstto the value of--burst-limit, meaning it should now be possible to fix client-side throttling issues encountered by the discovery client.This value is only configured if
--burst-limitis actually set. If--burst-limitis set to the default value, thendiscoveryBurstshould be left at its default of 300.Closes #13128