Skip to content

Remove global value does not take effect in dependency chart #6277

@bianpengyuan

Description

@bianpengyuan

This happens when running template command, not sure if it happens to other commands. When removing a value from global using null, it does not remove that value from subchart if it is declared as dependency. Using docs/examples/alpine as an example to reproduce:

diff --git a/docs/examples/alpine/charts/subchart/Chart.yaml b/docs/examples/alpine/charts/subchart/Chart.yaml
new file mode 100644
index 00000000..a9dbafe4
--- /dev/null
+++ b/docs/examples/alpine/charts/subchart/Chart.yaml
@@ -0,0 +1,5 @@
+apiVersion: v1
+appVersion: "1.0"
+description: A Helm chart for Kubernetes
+name: subchart
+version: 0.1.0
diff --git a/docs/examples/alpine/requirements.yaml b/docs/examples/alpine/requirements.yaml
new file mode 100644
index 00000000..75a09661
--- /dev/null
+++ b/docs/examples/alpine/requirements.yaml
@@ -0,0 +1,3 @@
+dependencies:
+  - name: subchart
+    version: 0.1.0
\ No newline at end of file
diff --git a/docs/examples/alpine/values.yaml b/docs/examples/alpine/values.yaml
index 225e0472..beb98559 100644
--- a/docs/examples/alpine/values.yaml
+++ b/docs/examples/alpine/values.yaml
@@ -4,3 +4,6 @@ image:
   pullPolicy: IfNotPresent
 
 restartPolicy: Never
+
+global:
+  key: val

Run helm template --set global.key=null --debug alpine, output is:

REVISION: 1
RELEASED: Fri Aug 23 11:31:51 2019
CHART: alpine-0.1.0
USER-SUPPLIED VALUES:
global:
  key: null

COMPUTED VALUES:
global: {}
image:
  pullPolicy: IfNotPresent
  repository: alpine
  tag: latest
restartPolicy: Never
subchart:
  global:
    key: val

HOOKS:
MANIFEST:

Output of helm version:
Client: &version.Version{SemVer:"v2.14.3", GitCommit:"0e7f3b6637f7af8fcfddb3d2941fcc7cbebb0085", GitTreeState:"clean"}

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugCategorizes issue or PR as related to a bug.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions