Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: helm/helm
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v3.18.0
Choose a base ref
...
head repository: helm/helm
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v3.18.1
Choose a head ref
  • 10 commits
  • 12 files changed
  • 7 contributors

Commits on May 27, 2025

  1. Revert "fix (helm) : toToml` renders int as float [ backport to v3 ]" 

    This change has caused issues with numerous charts around things
unrelated to toml. This is because of functions like typeIs/typeOf
being used and acted upon.

The change caused a significant regression.

Closes #30880

Signed-off-by: Matt Farina <matt@mattfarina.com>
(cherry picked from commit c5249c1)
    @mattfarina
    mattfarina committed May 27, 2025
    Configuration menu
    Copy the full SHA
    bec6609 View commit details
    Browse the repository at this point in the history

  2. Fix 3.18.0 regression: registry login with scheme 

    Helm 3.18.0 released an upgrade of ORAS from v1 to v2.

ORAS v2 correctly does not accept http/https scheme for registry login, while
ORAS v1 previously did. Even if v1 should not have, we want to preserve
backwards compatibility for Helm 3 users who pass the scheme.

This will be removed in Helm 4, where registry login will not accept http/https
scheme.

Co-authored-by: Andrew Block <andy.block@gmail.com>
Co-authored-by: Terry Howe <terrylhowe@gmail.com>

Signed-off-by: Scott Rigby <scott@r6by.com>
(cherry picked from commit c0f3ace)
    @scottrigby @mattfarina
    scottrigby authored and mattfarina committed May 27, 2025
    Configuration menu
    Copy the full SHA
    ea04cea View commit details
    Browse the repository at this point in the history

  3. Wait for Helm v4 before raising when platformCommand and Command are set 

    same for `PlatformHooks` and `hooks`.

When backporting a feature for Helm v3 we forgot to mark as deprecation
validations that will enforced in v4.

See (search for "Remove in Helm 4."):
- https://github.com/helm/helm/pull/13592/files#diff-fc137d62147eb6a9c89c0566479ff219320ca691f2505631ebacbe513bcc8108R268-R270

Fix:
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
(cherry picked from commit 5d9d9a0)
    @benoittgt @mattfarina
    benoittgt authored and mattfarina committed May 27, 2025
    Configuration menu
    Copy the full SHA
    7e8f534 View commit details
    Browse the repository at this point in the history

  4. Update pkg/plugin/plugin.go 

    Co-authored-by: George Jenkins <gvjenkins@gmail.com>
Signed-off-by: Benoit Tigeot <benoittgt@users.noreply.github.com>
(cherry picked from commit cda0865)
    @benoittgt @gjenkins8 @mattfarina
    2 people authored and mattfarina committed May 27, 2025
    Configuration menu
    Copy the full SHA
    24b4490 View commit details
    Browse the repository at this point in the history

  5. Update pkg/plugin/plugin.go 

    Co-authored-by: George Jenkins <gvjenkins@gmail.com>
Signed-off-by: Benoit Tigeot <benoittgt@users.noreply.github.com>
(cherry picked from commit dce60ad)
    @benoittgt @gjenkins8 @mattfarina
    2 people authored and mattfarina committed May 27, 2025
    Configuration menu
    Copy the full SHA
    e8bfa0e View commit details
    Browse the repository at this point in the history

  6. Prevent failure when resolving version tags in oras memory store 

    - The newReference() function transforms version tags by replacing + with _ for OCI compatibility
- But the code was using the original ref (with +) for TagBytes()
- Then it tries to find the tagged reference using parsedRef.String() (with _)
- This mismatch causes the Resolve method to fail with "not found"
- By using parsedRef.String() consistently in both places, the references will match and the lookup will succeed.

I extracted the TagBytes function to improve testability.
Push() includes several external calls that are hard to mock,
so isolating this logic makes testing more manageable.

Close: #30881
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
(cherry picked from commit f552b67)
    @benoittgt @mattfarina
    benoittgt authored and mattfarina committed May 27, 2025
    Configuration menu
    Copy the full SHA
    9db1a12 View commit details
    Browse the repository at this point in the history

  7. Prevent fetching newReference again as we have in calling method 

    Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
(cherry picked from commit c33215d)
    @benoittgt @mattfarina
    benoittgt authored and mattfarina committed May 27, 2025
    Configuration menu
    Copy the full SHA
    015531c View commit details
    Browse the repository at this point in the history

  8. fix(client): return nil on non-allowed media types 

    Signed-off-by: Brandt Keller <brandt.keller@defenseunicorns.com>
(cherry picked from commit c225c12)
    @brandtkeller @mattfarina
    brandtkeller authored and mattfarina committed May 27, 2025
    Configuration menu
    Copy the full SHA
    1a8507f View commit details
    Browse the repository at this point in the history

  9. fix(client): layers now returns manifest - remove duplicate from desc… 

    …riptors

Signed-off-by: Brandt Keller <brandt.keller@defenseunicorns.com>
(cherry picked from commit b07ab77)
    @brandtkeller @mattfarina
    brandtkeller authored and mattfarina committed May 27, 2025
    Configuration menu
    Copy the full SHA
    4da7015 View commit details
    Browse the repository at this point in the history

  10. fix(client): skipnode utilization for PreCopy 

    Co-authored-by: George Jenkins <gvjenkins@gmail.com>
Signed-off-by: Brandt Keller <43887158+brandtkeller@users.noreply.github.com>
(cherry picked from commit a18a52e)
    @brandtkeller @gjenkins8 @mattfarina
    2 people authored and mattfarina committed May 27, 2025
    Configuration menu
    Copy the full SHA
    f6f8700 View commit details
    Browse the repository at this point in the history
Loading