Skip to content

feat(helm): document --skip-schema-validation flag #1549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat(helm): document --skip-schema-validation flag #1549

wants to merge 1 commit into from

Conversation

anessi
Copy link

@anessi anessi commented Feb 1, 2024

Documentation for helm/helm#12743

@anessi anessi mentioned this pull request Feb 1, 2024
Merged
3 tasks
joebowbeer
joebowbeer reviewed Apr 5, 2024
View reviewed changes
Copy link

@joebowbeer joebowbeer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anessi Do the CLI docs need to be updated?

https://github.com/helm/helm-www?tab=readme-ov-file#updating-the-helm-cli-reference-docs

@anessi
Copy link
Author

anessi commented Apr 5, 2024 •
edited
Loading

@joebowbeer Thanks for the hint. I missed this. Now those files are updated as well.
You can also see there that the command line arg is added to the template command.

@sabre1041 FYI, as it relates to the other PR helm/helm#12743

@pull-request-size pull-request-size bot added size/L and removed size/XS labels Apr 5, 2024
@anessi anessi requested a review from joebowbeer April 8, 2024 15:04
joebowbeer
joebowbeer approved these changes Apr 8, 2024
View reviewed changes
Copy link

@joebowbeer joebowbeer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joebowbeer
Copy link

joebowbeer commented Apr 8, 2024 •
edited
Loading

@yxxhero PTAL

scottrigby
scottrigby requested changes Jun 11, 2024
View reviewed changes
Copy link
Member

@scottrigby scottrigby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, except one suggestion to help users with context.

@anessi anessi requested a review from scottrigby June 12, 2024 06:01
@scottrigby scottrigby added the awaiting release Feature needs to be merged and released before docs update label Aug 12, 2024
@scottrigby scottrigby removed the awaiting release Feature needs to be merged and released before docs update label Jan 10, 2025
@scottrigby
Copy link
Member

This was released in Helm 3.16.0 on August 11, but now this PR needs merge conflicts to be fixed

@anessi anessi force-pushed the feat/skip-schema-validation branch from 614cfe4 to f6592d0 Compare January 31, 2025 13:16
@anessi anessi force-pushed the feat/skip-schema-validation branch from f6592d0 to 85d4101 Compare January 31, 2025 13:20
@anessi
Copy link
Author

anessi commented Jan 31, 2025

@scottrigby : I fixed the PR, so better merge fast 😉

scottrigby
scottrigby approved these changes Jan 31, 2025
View reviewed changes
Copy link
Member

@scottrigby scottrigby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

Note this PR was significantly reduced in size, since we needed to update various things for CLI command documentation as part of 3.16.0 in this pr #1622. However, this note is important context explaining WHY. Thank you!

@anessi
feat(helm): document --skip-schema-validation flag
c4ecae7 
Signed-off-by: anessi <16045045+anessi@users.noreply.github.com>
@anessi anessi force-pushed the feat/skip-schema-validation branch from 85d4101 to c4ecae7 Compare August 4, 2025 07:44
TerryHowe
TerryHowe approved these changes Aug 6, 2025
View reviewed changes
Copy link
Contributor

@TerryHowe TerryHowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scottrigby scottrigby scottrigby approved these changes

+2 more reviewers

@joebowbeer joebowbeer joebowbeer approved these changes

@TerryHowe TerryHowe TerryHowe approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@anessi @joebowbeer @scottrigby @TerryHowe