fix(upgrade): using the values instead of --reuse-values #742
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Paolo Gallina <paologallina1992@gmail.com>
cd3f7d4 to
92f2542
Compare
3 tasks
This was referenced Jul 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The
cttool is leveraging the--reuse-valuevalues flag that is a bit controversial since it does not leverage the new values in the values.yaml. helm/helm#8085 helm/helm#3957This causes many pipeline to fail with false positives (each time you add a new default)
Currently, there is available different flags that overcome that issue "--reset-then-reuse-values", however I think it is better to actually use the values that are available instead of rely on a different flag that might be not available in all Helm versions.