Skip to content

Feature: add extra flags to skip helm dependencies download and upgrade Go to 1.23 #690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 8, 2024
Merged

Feature: add extra flags to skip helm dependencies download and upgrade Go to 1.23 #690

merged 4 commits into from
Nov 8, 2024

Conversation

cpanato
Copy link
Member

@cpanato cpanato commented Nov 4, 2024 •
edited
Loading

What this PR does / why we need it:

  • Feature: add extra flags to skip helm dependencies download
  • upgrade go to 1.23
  • fix goreleaser

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged):

Fixes #541

$ ct lint --config ct.yaml
Linting charts...

------------------------------------------------------------------------------------------------------------------------
 Charts to be processed:
------------------------------------------------------------------------------------------------------------------------
 fulcio => (version: "2.6.4", path: "charts/fulcio")
------------------------------------------------------------------------------------------------------------------------

"sigstore" already exists with the same configuration, skipping
2>>>>>Hang tight while we grab the latest from your chart repositories...
...Successfully got an update from the "akhq" chart repository
...Successfully got an update from the "chainguard" chart repository
...Successfully got an update from the "gatekeeper" chart repository
...Successfully got an update from the "nginx-stable" chart repository
...Successfully got an update from the "neuvector" chart repository
...Successfully got an update from the "coredns" chart repository
...Successfully got an update from the "ingress-nginx" chart repository
...Successfully got an update from the "keycloak" chart repository
...Successfully got an update from the "falcosecurity" chart repository
...Successfully got an update from the "cnpg" chart repository
...Successfully got an update from the "sigstore" chart repository
...Successfully got an update from the "crossplane-stable" chart repository
...Successfully got an update from the "argo" chart repository
...Successfully got an update from the "external-secrets" chart repository
...Successfully got an update from the "cpanato" chart repository
...Successfully got an update from the "gitlab" chart repository
...Successfully got an update from the "prometheus-community" chart repository
...Successfully got an update from the "stable" chart repository
Update Complete. ⎈Happy Helming!⎈
Saving 1 charts
Downloading ctlog from repo https://sigstore.github.io/helm-charts
Deleting outdated charts
Linting chart "fulcio => (version: \"2.6.4\", path: \"charts/fulcio\")"
Checking chart "fulcio => (version: \"2.6.4\", path: \"charts/fulcio\")" for a version bump...
Old chart version: 2.6.3
New chart version: 2.6.4
Chart version ok.
Validating /Users/cpanato/code/src/github.com/sigstore/helm-charts/charts/fulcio/Chart.yaml...
Validation success! 👍

Linting chart with values file "charts/fulcio/ci/ci-values.yaml"...

==> Linting charts/fulcio
[INFO] Chart.yaml: icon is recommended

1 chart(s) linted, 0 chart(s) failed

------------------------------------------------------------------------------------------------------------------------
 ✔︎ fulcio => (version: "2.6.4", path: "charts/fulcio")
------------------------------------------------------------------------------------------------------------------------

after with the --skip-helm-dependencies flag enabled :

$ ct lint --config ct.yaml --skip-helm-dependencies
Linting charts...

------------------------------------------------------------------------------------------------------------------------
 Charts to be processed:
------------------------------------------------------------------------------------------------------------------------
 fulcio => (version: "2.6.4", path: "charts/fulcio")
------------------------------------------------------------------------------------------------------------------------

"sigstore" already exists with the same configuration, skipping
Linting chart "fulcio => (version: \"2.6.4\", path: \"charts/fulcio\")"
Checking chart "fulcio => (version: \"2.6.4\", path: \"charts/fulcio\")" for a version bump...
Old chart version: 2.6.3
New chart version: 2.6.4
Chart version ok.
Validating /Users/cpanato/code/src/github.com/sigstore/helm-charts/charts/fulcio/Chart.yaml...
Validation success! 👍

Linting chart with values file "charts/fulcio/ci/ci-values.yaml"...

==> Linting charts/fulcio
[INFO] Chart.yaml: icon is recommended

1 chart(s) linted, 0 chart(s) failed

------------------------------------------------------------------------------------------------------------------------
 ✔︎ fulcio => (version: "2.6.4", path: "charts/fulcio")
------------------------------------------------------------------------------------------------------------------------
All charts linted successfully

Special notes for your reviewer:

@cpanato
add option to skip run helm dependency build command
a6947de 
Signed-off-by: cpanato <ctadeu@gmail.com>
@cpanato
upgrade to go 1.23
2d98129 
Signed-off-by: cpanato <ctadeu@gmail.com>
@cpanato
fix goreleaser
f32a50d 
Signed-off-by: cpanato <ctadeu@gmail.com>
@cpanato cpanato mentioned this pull request Nov 4, 2024
Closed
@cpanato cpanato requested a review from davidkarlsen November 4, 2024 15:03
@cpanato
sync go.mod
dc485bf 
Signed-off-by: cpanato <ctadeu@gmail.com>
@pull-request-size pull-request-size bot added size/M and removed size/L labels Nov 4, 2024
@unguiculus unguiculus merged commit 3e61ea4 into helm:main Nov 8, 2024
4 checks passed
@cpanato cpanato deleted the GH-541 branch November 8, 2024 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@unguiculus unguiculus unguiculus approved these changes

@davidkarlsen davidkarlsen Awaiting requested review from davidkarlsen

Assignees
No one assigned
Labels
size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature: add extra flags to skip helm dependencies download
2 participants
@cpanato @unguiculus