Skip to content

Fix exit code when test with multiple custom CI values files fails #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 11, 2018
Merged

Fix exit code when test with multiple custom CI values files fails #18

merged 2 commits into from
Sep 11, 2018

Conversation

unguiculus
Copy link
Member

No description provided.

@unguiculus
Fix exit code when test with multiple custom CI values files fails
64c1e52 
Signed-off-by: Reinhard Nägele <unguiculus@gmail.com>
@rimusz
Copy link
Contributor

rimusz commented Sep 11, 2018

LGTM

rimusz
rimusz reviewed Sep 11, 2018
View reviewed changes
Copy link
Contributor

@rimusz rimusz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image gcr.io/kubernetes-charts-ci/chart-testing:v1.0.4 is not available yet

@unguiculus
Merge remote-tracking branch 'upstream/master' into feature/exit-code
f99086b 
Signed-off-by: Reinhard Nägele <unguiculus@gmail.com>
@unguiculus
Copy link
Member Author

Image pushed.

@unguiculus unguiculus merged commit 3b5e7fa into helm:master Sep 11, 2018
@unguiculus unguiculus deleted the feature/exit-code branch September 11, 2018 13:56
@rimusz
Copy link
Contributor

rimusz commented Sep 11, 2018

👍

@unguiculus unguiculus mentioned this pull request Sep 29, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@rimusz rimusz rimusz left review comments

Reviewers whose approvals may not affect merge requirements
Assignees

@mattfarina mattfarina

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@unguiculus @rimusz @mattfarina