error when tested chart folder name is long #343
Description
Is this a request for help?: maybe?
Is this a BUG REPORT or FEATURE REQUEST? (choose one): depends on your point of view, i would call it a BUG REPORT but the engineer in me could argue its a FEATURE REQUEST.
Version of Helm and Kubernetes:
helm version
kubectl version
ct version
version.BuildInfo{Version:"v3.6.1", GitCommit:"61d8e8c4a6f95540c15c6a65f36a6dd0a45e7a2f", GitTreeState:"dirty", GoVersion:"go1.16.5"}
Client Version: version.Info{Major:"1", Minor:"19", GitVersion:"v1.19.7", GitCommit:"1dd5338295409edcfff11505e7bb246f0d325d15", GitTreeState:"clean", BuildDate:"2021-01-13T13:23:52Z", GoVersion:"go1.15.5", Compiler:"gc", Platform:"darwin/amd64"}
Server Version: version.Info{Major:"1", Minor:"21", GitVersion:"v1.21.1", GitCommit:"5e58841cce77d4bc13713ad2b91fa0d961e69192", GitTreeState:"clean", BuildDate:"2021-05-21T23:01:33Z", GoVersion:"go1.16.4", Compiler:"gc", Platform:"linux/amd64"}
Version: 3.4.0
Git commit: 68a43ac09699ef9473266457e893a7ddd7ef6b5b
Date: 2021-05-22
License: Apache 2.0
What happened:
when running ct install --charts charts/ploigos-workflow-everything-tekton-pipeline I get the following:
short version:
Error: release name "ploigos-workflow-everything-tekton-pipeline-8y2c24lws7" exceeds max length of 53
long version
Installing charts...
Version increment checking disabled.
------------------------------------------------------------------------------------------------------------------------
Charts to be processed:
------------------------------------------------------------------------------------------------------------------------
ploigos-workflow-everything-tekton-pipeline => (version: "0.16.2", path: "charts/ploigos-workflow-everything-tekton-pipeline")
------------------------------------------------------------------------------------------------------------------------
Hang tight while we grab the latest from your chart repositories...
...Successfully got an update from the "ingress-nginx" chart repository
...Successfully got an update from the "haproxy-ingress" chart repository
...Successfully got an update from the "haproxytech" chart repository
...Successfully got an update from the "rhacs" chart repository
...Successfully got an update from the "gitlab" chart repository
Update Complete. ⎈Happy Helming!⎈
Saving 1 charts
Dependency ploigos-workflow-tekton-shared-resources did not declare a repository. Assuming it exists in the charts directory
Deleting outdated charts
walk.go:74: found symbolic link in path: /Users/itewk/Projects/SPO/ploigos-charts/charts/ploigos-workflow-everything-tekton-pipeline/charts/ploigos-workflow-tekton-shared-resources resolves to /Users/itewk/Projects/SPO/ploigos-charts/charts/ploigos-workflow-tekton-shared-resources
walk.go:74: found symbolic link in path: /Users/itewk/Projects/SPO/ploigos-charts/charts/ploigos-workflow-everything-tekton-pipeline/charts/ploigos-workflow-tekton-shared-resources/charts/ploigos-workflow-shared-resources resolves to /Users/itewk/Projects/SPO/ploigos-charts/charts/ploigos-workflow-shared-resources
walk.go:74: found symbolic link in path: /Users/itewk/Projects/SPO/ploigos-charts/charts/ploigos-workflow-everything-tekton-pipeline/tmpcharts/ploigos-workflow-tekton-shared-resources/charts/ploigos-workflow-shared-resources resolves to /Users/itewk/Projects/SPO/ploigos-charts/charts/ploigos-workflow-shared-resources
Installing chart 'ploigos-workflow-everything-tekton-pipeline => (version: "0.16.2", path: "charts/ploigos-workflow-everything-tekton-pipeline")'...
Installing chart with values file 'charts/ploigos-workflow-everything-tekton-pipeline/ci/test-values.yaml'...
Creating namespace 'ploigos-workflow-everything-tekton-pipeline-8y2c24lws7'...
namespace/ploigos-workflow-everything-tekton-pipeline-8y2c24lws7 created
walk.go:74: found symbolic link in path: /Users/itewk/Projects/SPO/ploigos-charts/charts/ploigos-workflow-everything-tekton-pipeline/charts/ploigos-workflow-tekton-shared-resources resolves to /Users/itewk/Projects/SPO/ploigos-charts/charts/ploigos-workflow-tekton-shared-resources
walk.go:74: found symbolic link in path: /Users/itewk/Projects/SPO/ploigos-charts/charts/ploigos-workflow-everything-tekton-pipeline/charts/ploigos-workflow-tekton-shared-resources/charts/ploigos-workflow-shared-resources resolves to /Users/itewk/Projects/SPO/ploigos-charts/charts/ploigos-workflow-shared-resources
Error: release name "ploigos-workflow-everything-tekton-pipeline-8y2c24lws7" exceeds max length of 53
What you expected to happen:
No error. either "it just works" by shortnening the release name, or have an option to specify a release name.
How to reproduce it (as minimally and precisely as possible): 100%
Anything else we need to know:
I dug through the code and found these relevent sections:
- https://github.com/helm/chart-testing/blob/main/pkg/chart/chart.go#L656
- https://github.com/helm/chart-testing/blob/main/pkg/chart/chart.go#L663
- https://github.com/helm/chart-testing/blob/main/pkg/chart/chart.go#L202-L216
Which I am reading as that the release name used during testing is always based on the folder name, or if the folder path was . then the chart name is used from Chart.yaml. The problem is if fodler name/chart name is to long. When using helm directly one can specify the name to use, but there is no option to do that with chart-tester making it impossible to test this chart (without changing the folder name).
Also https://github.com/helm/chart-testing/blob/main/pkg/util/util.go#L226-L235 looks like it should be making the release name short enough, but its cutting it down to 63 but the error is about 53.