Chart repo URLs with query strings cause errors #30
Description
Running this with a chart repo that has a query string (e.g. a private blob with SAS token) causes an error. This appears to be because the name of the chart is being taken as all the characters before the last = instead of the first.
.mytestenv file:
CHART_REPOS=( "myrepo=https://myblob.blob.core.windows.net/helm/?se=2020-01-01&sp=rl&sv=2018-01-01&sr=c&sig=redacted-token" )
command:
docker run --rm -v "$(pwd):/workdir" --workdir /workdir quay.io/helmpack/chart-testing:v1.1.0 chart_test.sh --no-install --config .mytestenv
result:
--------------------------------------------------------------------------------
Environment:
REMOTE=origin
TARGET_BRANCH=master
CHART_DIRS=charts
EXCLUDED_CHARTS=
CHART_REPOS=myrepo=https://myblob.blob.core.windows.net/helm/?se=2020-01-01&sp=rl&sv=2018-01-01&sr=c&sig=redacted-token
TIMEOUT=300
LINT_CONF=/testing/etc/lintconf.yaml
CHART_YAML_SCHEMA=/testing/etc/chart_schema.yaml
VALIDATE_MAINTAINERS=false
GITHUB_INSTANCE=https://github.com
CHECK_VERSION_INCREMENT=true
--------------------------------------------------------------------------------
Charts to be installed and tested: charts/my-chart
Initializing Helm client...
Creating /root/.helm
Creating /root/.helm/repository
Creating /root/.helm/repository/cache
Creating /root/.helm/repository/local
Creating /root/.helm/plugins
Creating /root/.helm/starters
Creating /root/.helm/cache/archive
Creating /root/.helm/repository/repositories.yaml
Adding stable repo with URL: https://kubernetes-charts.storage.googleapis.com
Adding local repo with URL: http://127.0.0.1:8879/charts
$HELM_HOME has been configured at /root/.helm.
Not installing Tiller due to 'client-only' flag having been set
Happy Helming!
Error: Looks like "https://myblob.blob.core.windows.net/helm/?se=2020-01-01&sp=rl&sv=2018-01-01&sr=c&sig=redacted-token" is not a valid chart repository or cannot be reached: open /root/.helm/repository/cache/myrepo=https:/myblob.blob.core.windows.net/helm/?se=2020-01-01&sp=rl&sv=2018-01-01&sr=c&sig-index.yaml: no such file or directory