Fix charts_dir depth #62
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ahmed AbouZaid <ahmed.abouzaid@camunda.com>
9465696 to
1d2f81d
Compare
unguiculus
requested changes
Feb 19, 2021
monotek
suggested changes
Mar 7, 2021
| @@ -225,7 +225,7 @@ lookup_changed_charts() { | |||
| local changed_files | |||
| changed_files=$(git diff --find-renames --name-only "$commit" -- "$charts_dir") | |||
|
|
|||
| local depth=$(( $(tr "/" "\n" <<< "$charts_dir" | wc -l) + 1 )) | |||
| local depth=$(( $(tr "/" "\n" <<< "$charts_dir" | wc -l) )) | |||
There was a problem hiding this comment.
This should do the drick:
Suggested change
| local depth=$(( $(tr "/" "\n" <<< "$charts_dir" | wc -l) )) | |
| local depth=$(( $(tr "/" "\n" <<< "$charts_dir" | sed '/^\(\.\)*$/d' | wc -l) + 1 )) |
sed deletes empty lines which should fix the absolute path problem and deletes lines which only contain a ".".
|
@aabouzaid |
|
Superseded by #83 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A tiny fix to make charts_dir works again with the current working dir.
Related to: #61