Skip to content

Always fail to find changed charts with deeply nested (>2 levels) charts_dir #46

New issue
New issue
Closed
#47
Closed
Always fail to find changed charts with deeply nested (>2 levels) charts_dir#46
#47
@LukeCarrier

Description

@LukeCarrier
LukeCarrier
opened on Oct 16, 2020

It looks as though this code will fail when the charts directory is nested below another directory:

chart-releaser-action/cr.sh

Lines 202 to 209 in 06d81fa

local fields
if [[ "$charts_dir" == '.' ]]; then
fields='1'
else
fields='1,2'
fi
cut -d '/' -f "$fields" <<< "$changed_files" | uniq | filter_charts

For an example of this, see rook/rook, where charts_dir is cluster/charts:

Would you accept a PR to fix this?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions