Skip to content

Precompute portal node graphs #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 53 commits into from
Closed

Precompute portal node graphs #4

wants to merge 53 commits into from

Conversation

jere8184
Copy link

@jere8184 jere8184 commented Oct 15, 2024 •
edited
Loading

WIP

heinezen and others added 30 commits September 8, 2024 01:29
@heinezen
gamestate: Make component classes 'final'.
170e43f
@heinezen
doc: Change recommended entrypoint for Windows build.
44952e5
@TheJJ
Merge pull request SFTtech#1689 from heinezen/fix/win_build_instructions
81a0a55 
Change recommended entrypoint for Windows build
@TheJJ
Merge pull request SFTtech#1687 from heinezen/feature/final_components
380d2e9 
Make component classes `final`
renderer: Update syntax of GlUniformBuffer to match that of GlUniform…
c6db4fb 
…Input
@EdvinLndh
renderer: Update syntax of GlUniformBuffer to match that of GlUniform…
6256c66 
…Input
@EdvinLndh
Added syntax changes to GlUniformBufferInput class.
623554e
@EdvinLndh
Merge branch 'uniform_syntax_change' of github.com:EdvinLndh/openage …
0c1a368 
…into uniform_syntax_change
@EdvinLndh
Changed uniforms attribute from unordered_map to vector
de212cb
@heinezen
Merge pull request SFTtech#1690 from EdvinLndh/uniform_syntax_change
66098ce 
Update syntax of GlUniformBuffer to match that of GlUniformInput SFTtech#1683
@PRIYANKjakharia
Update README.md
b3a21a3 
correction of a few grammatical errors and typos
@PRIYANKjakharia @heinezen
Update README.md
8bad4db 
Co-authored-by: Christoph Heine <6852422+heinezen@users.noreply.github.com>
@PRIYANKjakharia @heinezen
Update README.md
e8bf591 
Co-authored-by: Christoph Heine <6852422+heinezen@users.noreply.github.com>
@heinezen
Merge pull request SFTtech#1694 from PRIYANKjakharia/patch-1
02d3242 
Update README.md
@heinezen
renderer: Fix tex unit assignment for std::optional type.
03c1592
@TheJJ
Merge pull request SFTtech#1695 from heinezen/fix/texunit_binding
fb88dfc 
Fix tex unit assignment to `std::optional` type
@heinezen
buildsys: Remove unused imports.
ac2dbbd
@heinezen
buildsys: Deactivate _PyTraceback_Add import.
ce1f7f8
@heinezen
buildsys: Add comments explaining why _PyTraceback_Add is no longer u…
98908b0 
…sed.
@TheJJ
Merge pull request SFTtech#1697 from heinezen/fix/py_traceback
a3df307 
Deactivate `_PyTraceback_Add`
@heinezen
doc: Update macOS build instructions.
8d5629a
@heinezen
ci: Update macOS CI config.
a66e08b
@heinezen
ci: Update versions of deprecated actions.
656ce84
@heinezen
renderer: Fix lock of resource reads in render entity.
f9ec53b
@heinezen
renderer: Add RenderEntity base class for common methods.
cfd835f
@heinezen
refactor: Shorten render entity class name in HUD render stage.
d44f903
@heinezen
refactor: Shorten render entity class name in Terrain render stage.
3f73385
@heinezen
refactor: Shorten render entity class name in world render stage.
b3295e3
@heinezen
renderer: Return copies instead of referenced in terrain render enity.
5e7a768 
Makes the updates thread-safe.
@heinezen
renderer: Fix lock of resource reads in hud render entity.
8314b6c
@jere8184 jere8184 changed the title Precompute portal node graphs [#1674](https://github.com/SFTtech/openage/issues/1674) Precompute portal node graphs [1674](https://github.com/SFTtech/openage/issues/1674) Nov 6, 2024
@jere8184 jere8184 changed the title Precompute portal node graphs [1674](https://github.com/SFTtech/openage/issues/1674) Precompute portal node graphs (https://github.com/SFTtech/openage/issues/1674) Nov 6, 2024
@jere8184 jere8184 changed the title Precompute portal node graphs (https://github.com/SFTtech/openage/issues/1674) Precompute portal node graphs Nov 6, 2024
@jere8184 jere8184 requested a review from heinezen November 6, 2024 14:01
@jere8184
Copy link
Author

jere8184 commented Nov 6, 2024

I've observed a 17% increase in speed, with my current changes.

@heinezen
Copy link
Owner

heinezen commented Nov 6, 2024

I'm going to take another look.

heinezen
heinezen requested changes Nov 7, 2024
View reviewed changes
Copy link
Owner

@heinezen heinezen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor points, but it already looks pretty refined.

EdvinLndh and others added 12 commits November 7, 2024 22:54
@EdvinLndh @heinezen
Renderer: Added camera boundaries to CameraManager and clamping to th…
73f06b7 
…e camera movement.
@EdvinLndh @heinezen
Refactoring and documentation.
85918c9
@EdvinLndh @heinezen
Added constructor for CameraBoundaries.
b907a7d
@EdvinLndh @heinezen
Struct refactoring
780949f
@EdvinLndh @heinezen
Refactoring and cleanup
1556502
@EdvinLndh @heinezen
Changed default minimum boundary to be largest negative value instead…
0c129fb 
… of smallest positive value.
@EdvinLndh @heinezen
Fixes for Y boundary
59cee6a
@heinezen
renderer: Create boundaries.cpp file for compilation checks.
af804e6
@heinezen
renderer: Add method to change camera boundaries in cam manager.
179e1ad
@heinezen
renderer: Rename current hardcoded camera boundaries.
6d6a2dd
@heinezen
Include missing email for SFTtech#1691
a3376ca
@heinezen
Merge pull request SFTtech#1691 from EdvinLndh/add_camera_boundaries
2170ff5 
Renderer: Added camera boundaries to CameraManager and clamping SFTtech#1682.
@jere8184 jere8184 requested a review from heinezen November 10, 2024 18:53
heinezen
heinezen requested changes Nov 13, 2024
View reviewed changes
Copy link
Owner

@heinezen heinezen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Final change requests I hope :D

@jere8184
Copy link
Author

jere8184 commented Nov 15, 2024 •
edited
Loading

I'm now seeing a performance decrease. I've messed around with valgrind and from a quick glance I think the map look ups are causing this. :/.

edit: I've got a plan.

@jere8184
Copy link
Author

@heinezen feel free to take a look, pretty decent performance increase observed :)

@jere8184 jere8184 requested a review from heinezen November 16, 2024 16:41
@heinezen
Copy link
Owner

Nice, I think this should be ready now :) We can always improve the code later.

I have just a few requests before merging:

@jere8184 jere8184 closed this Nov 18, 2024
@heinezen heinezen mentioned this pull request Nov 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heinezen heinezen Awaiting requested review from heinezen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jere8184 @heinezen @TheJJ @EdvinLndh @PRIYANKjakharia