Skip to content

Add -tls option to allow tls without certs for server-only TLS #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 13, 2020
Merged

Add -tls option to allow tls without certs for server-only TLS #24

merged 1 commit into from
Mar 13, 2020

Conversation

dangogh
Copy link

@dangogh dangogh commented Mar 9, 2020

Adds a -tls option for 1-way TLS for server-side without requiring certs for client-side. In this case, an empty tls.Config will enable TLS.

@dangogh dangogh mentioned this pull request Mar 10, 2020
Closed
rogpeppe
rogpeppe reviewed Mar 13, 2020
View reviewed changes
Copy link

@rogpeppe rogpeppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thanks! Just to check before merging: I'm not able to QA this - have you checked that it works for real?

@dangogh
Copy link
Author

dangogh commented Mar 13, 2020

Yep.. I'm using it actively -- really helps to compare the lag in a topic between two user groups..

@rogpeppe
Copy link

Thanks for the quick response.

@rogpeppe rogpeppe merged commit 3c1c580 into heetch:master Mar 13, 2020
@dangogh dangogh mentioned this pull request Mar 15, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@rogpeppe rogpeppe rogpeppe left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dangogh @rogpeppe