Skip to content

Conversation

hebasto
Copy link
Owner

@hebasto hebasto commented Nov 27, 2023

The first commit fixes a regression, which makes tests running with the empty CMAKE_REQUIRED_FLAGS variable. It was introduced during updating the code for the minimum CMake 3.16.

The second commit mirrors bitcoin#28919.

@hebasto
Copy link
Owner Author

hebasto commented Nov 27, 2023

Friendly ping @TheCharlatan @fanquake @theuni @vasild @pablomartin4btc :)

Copy link

@pablomartin4btc pablomartin4btc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK 02392e7

I've tried to validate 2nd. commit on qemu but it didn't seem to work (got the same message as on an Ubuntu build) so pending to test this for me until I manage to get the real hardware.
-- Performing Test HAVE_ARM64_CRC32C
-- Performing Test HAVE_ARM64_CRC32C - Failed

@hebasto hebasto merged commit 399642a into cmake-staging Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants