cmake: Port PR30051 from the master branch #317
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @josibake @paplorinc as the ported commit authors |
|
utACK 6582963 Q: did you discover this after a rebase, or what did "to fix compiling" refer to? |
l0rinc
reviewed
Aug 9, 2024
The first commit breaks compiling. Noticed due to bitcoin#30454 (comment). |
Otherwise, the next commit will fail to compile.
Sanity check that using CKey/CPubKey directly vs using secp256k1_keypair objects returns the same results for BIP341 key tweaking. Co-authored-by: l0rinc <pap.lorinc@gmail.com>
6582963 to
7f4cad8
Compare
|
I've reordered commits to avoid CI failure. |
Cool way to demonstrate the need for this change :) ACK 7f4cad8 |
|
ACK 7f4cad8 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ports a single commit from bitcoin#30051 and amends the
test_bitcointarget to fix compiling.