Skip to content

Conversation

hebasto
Copy link
Owner

@hebasto hebasto commented Aug 4, 2024

To detect cross-compiling, the host and build platforms are compared. The build variable is always an output of config.sub, but the host is not. This can lead to false results. For example, on OpenBSD:

  • host=amd64-unknown-openbsd7.5
  • build=x86_64-unknown-openbsd7.5

This change replaces the host variable with canonical_host, which is also always an output of config.sub. Thus, canonical_host and build are always properly comparable.


There are a few same/similar cases in the master branch. So I'm going to investigate them further. and submit a PR.

To detect cross-compiling, the host and build platforms are compared.
The `build` variable is always an output of `config.sub`, but the `host`
is not. This can lead to false results. For example, on OpenBSD:
 - host=amd64-unknown-openbsd7.5
 - build=x86_64-unknown-openbsd7.5

This change replaces the `host` variable with `canonical_host`, which is
also always an output of `config.sub`. Thus, `canonical_host` and
`build` are always properly comparable.
@hebasto
Copy link
Owner Author

hebasto commented Aug 4, 2024

Friendly ping @theStack who reported this bug offline.

@hebasto hebasto marked this pull request as draft August 4, 2024 21:47
@hebasto
Copy link
Owner Author

hebasto commented Aug 4, 2024

Drafted as this PR breaks cross-compiling convention for Guix builds:

  • the staging branch:
$ make print-crosscompiling HOST=x86_64-linux-gnu
crosscompiling=TRUE
  • this PR:
$ make print-crosscompiling HOST=x86_64-linux-gnu
crosscompiling=FALSE

@hebasto
Copy link
Owner Author

hebasto commented Aug 4, 2024

More correct change is here: bitcoin#30584.

@hebasto hebasto closed this Aug 4, 2024
hebasto pushed a commit that referenced this pull request Aug 16, 2025
The `-assumevalid` option skips script verification for a specified block and all its ancestors during Initial Block Download.
Many new users are surprised when this suddenly slows their node to a halt.
This commit adds a log message to clearly indicate when this optimization ends and full validation begins (and vice versa).

When using `-assumeutxo`, logging is suppressed for the active assumed-valid chainstate and for the background validation chainstate to avoid the confusing toggles.

-------

> cmake -B build && cmake --build build && mkdir -p demo && build/bin/bitcoind -datadir=demo -stopatheight=500 | grep 'signature validation'

```
2025-08-08T20:59:21Z Disabling signature validations at block #1 (00000000839a8e6886ab5951d76f411475428afc90947ee320161bbf18eb6048).
2025-08-08T20:59:21Z Enabling signature validations at block #100 (000000007bc154e0fa7ea32218a72fe2c1bb9f86cf8c9ebf9a715ed27fdb229a).
2025-08-08T20:59:21Z Disabling signature validations at block #200 (000000008f1a7008320c16b8402b7f11e82951f44ca2663caf6860ab2eeef320).
2025-08-08T20:59:21Z Enabling signature validations at block #300 (0000000062b69e4a2c3312a5782d7798b0711e9ebac065cd5d19f946439f8609).
```
hebasto pushed a commit that referenced this pull request Aug 16, 2025
…hange

fab2980 assumevalid: log every script validation state change (Lőrinc)

Pull request description:

  The `-assumevalid` option skips script verification for a specified block and all its ancestors during Initial Block Download.
  Many new [users are surprised](bitcoin#32832) when this suddenly slows their node to a halt.
  This commit adds a log message to clearly indicate when this optimization ends and full validation begins (and vice versa).

  <details>
  <summary>Testing instructions</summary>

  The behavior can easily be tested by adding this before the new log:
  ```C++
      // TODO hack to enable/disable script checks based on block height for testing purposes
           if (pindex->nHeight < 100) fScriptChecks = false;
      else if (pindex->nHeight < 200) fScriptChecks = true;
      else if (pindex->nHeight < 300) fScriptChecks = false;
      else if (pindex->nHeight < 400) fScriptChecks = true;
  ```
  and exercise the new code with:
  ```bash
  cmake -B build && cmake --build build && mkdir -p demo && build/bin/bitcoind -datadir=demo -stopatheight=500 | grep 'signature validation'
  ```
  showing something like:
  * Disabling signature validations at block #1 (00000000839a8e6886ab5951d76f411475428afc90947ee320161bbf18eb6048).
  * Enabling signature validations at block #100 (000000007bc154e0fa7ea32218a72fe2c1bb9f86cf8c9ebf9a715ed27fdb229a).
  * Disabling signature validations at block #200 (000000008f1a7008320c16b8402b7f11e82951f44ca2663caf6860ab2eeef320).
  * Enabling signature validations at block #300 (0000000062b69e4a2c3312a5782d7798b0711e9ebac065cd5d19f946439f8609).

  </details>

ACKs for top commit:
  achow101:
    ACK fab2980
  ajtowns:
    crACK fab2980
  davidgumberg:
    untested crACK bitcoin@fab2980

Tree-SHA512: e90b66f7423b639356daace476942ce83e65e70466544394cbe2f15738bdbf716163eaf590c64c5448f9b41aeeaafe3342c48c6a7a478678a70b0310ca94e11d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant