Skip to content

cmake: Backport changes from the master branch #132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 1, 2024
Merged

cmake: Backport changes from the master branch #132

merged 2 commits into from
Apr 1, 2024

Conversation

hebasto
Copy link
Owner

@hebasto hebasto commented Apr 1, 2024

This PR:

  1. Backports changes from net: support unix domain sockets for -proxy and -onion bitcoin/bitcoin#27375.
  2. Aligns symbol checks with random: drop syscall wrapper usage for getrandom() bitcoin/bitcoin#27699.

A possible way to review this PR and the whole symbol check logic is to observe the Autotools vs CMake diff in the config/bitcoin-config.h:

./autogen.sh
./configure
cmake -B build
diff -u src/config/bitcoin-config.h build/src/config/bitcoin-config.h

@hebasto
Copy link
Owner Author

hebasto commented Apr 1, 2024

Friendly ping @vasild @m3dwards @pablomartin4btc @TheCharlatan @fanquake @maflcko @theuni :)

@hebasto hebasto mentioned this pull request Apr 1, 2024
Closed
TheCharlatan
TheCharlatan approved these changes Apr 1, 2024
View reviewed changes
Copy link

@TheCharlatan TheCharlatan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK be04ac9

@hebasto hebasto merged commit 00715fd into cmake-staging Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@TheCharlatan TheCharlatan TheCharlatan approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hebasto @TheCharlatan