cmake: Rework bitcoin_crypto library script after the recent sync to the master branch
#108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix a wrong implementation, which was caused by the confusion between Core's "--enable-asm" and libsecp's "--with-asm".
Align `bitcoin_crypto` library implementation with: - bitcoin#29407 - bitcoin#29528 Note. Failed to present this change as git-autosquash-ready.
There was a problem hiding this comment.
crACK 4e19692
- Verified the mentioned
master's PRs ASMoption (& references) removed (1)- Making
crypto/sha256_sse4.cppsource part of thebitcoin_cryptolibrary (libbitcoin_crypto_base) (2) - Build secp256k1 with
ASM(3)
tACK 4e19692
- The following doesn't show up anymore in the summary (1):
Use assembly routines ................. ON - (2)
Building CXX object src/crypto/CMakeFiles/bitcoin_crypto.dir/sha256_sse4.cpp.o - (3)
Building C object CMakeFiles/secp256k1.dir/
-DUSE_ASM_X86_64=1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Align
bitcoin_cryptolibrary implementation with:Note. Failed to present this change as git-autosquash-ready.