cmake, ci: Ensure minimum supported g++ version in CI jobs #147
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mirrors minimum g++-11 requirements from bitcoin#29091. 1. Update gcc version in the "ubuntu-jammy-native" job. 2. Switch the "cross-build" task to the debian::bookworm image, which effectively bumps `x86_64-w64-mingw32-g++-posix` version to 12.2
|
Friendly ping @pablomartin4btc @m3dwards @vasild :) |
|
Is the reason for changing the cross build task to use debian::bookworm to have at least some builds happening on gcc 12 or is this version of mingw32 required for something that otherwise wasn't possible? I don't have an objection either way, just interested in the motivation. |
The motivation is for mingw32 cross-compiler. Anyway, these CI scripts won't go to the master branch :) |
|
utACK 475cf6d |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR follows the minimum g++-11 requirements from bitcoin#29091:
Update gcc version in the "ubuntu-jammy-native" job.
Switch the "cross-build" task to the debian::bookworm image, which effectively bumps
x86_64-w64-mingw32-g++-posixversion to 12.2.This PR should be merged before the next sync/rebase cycle, which is about to happen.