Skip to content

Add "Clang-SNAPSHOT" workflow #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 21, 2025
Merged

Add "Clang-SNAPSHOT" workflow #34

merged 1 commit into from
Jan 21, 2025

Conversation

hebasto
Copy link
Owner

@hebasto hebasto commented Jan 20, 2025 •
edited
Loading

Inspired by bitcoin/bitcoin#31691.

@hebasto hebasto force-pushed the 250120-clang-snapshot branch 2 times, most recently from 07d3fc3 to d3d76eb Compare January 20, 2025 15:52
@hebasto hebasto mentioned this pull request Jan 20, 2025
Merged
maflcko
maflcko reviewed Jan 20, 2025
View reviewed changes
Copy link

@maflcko maflcko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

concept ack

.github/workflows/clang.yml Outdated
run: >
cmake -B build \
-DCMAKE_C_COMPILER=clang-${LLVM_VERSION} \
-DCMAKE_CXX_COMPILER=clang++-${LLVM_VERSION} \
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could add another one for libc++?

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure thing :)

Added.

@hebasto hebasto force-pushed the 250120-clang-snapshot branch from d3d76eb to 33dc31a Compare January 21, 2025 08:52
@hebasto hebasto merged commit 9233062 into main Jan 21, 2025
2 checks passed
@hebasto hebasto deleted the 250120-clang-snapshot branch January 21, 2025 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@maflcko maflcko maflcko left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hebasto @maflcko