Use separate networks in Traefik example #254
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The whole point of using a Docker socket proxy like CetusGuard is to limit access to the Docker socket. The main purpose of Traefik is exposing HTTP/TCP/UDP services to the public. Such services must share a network with Traefik to be discovered and routed to, but this must not be a network with the Docker socket proxy. Only services which actually needs access to the Docker socket must be in such a network, in this case only Traefik.
|
I also use independent networks in my personal infrastructure, these examples are simplified, but it makes sense to apply this change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The whole point of using a Docker socket proxy like CetusGuard is to limit access to the Docker socket. The main purpose of Traefik is exposing HTTP/TCP/UDP services to the public. Such services must share a network with Traefik to be discovered and routed to, but this must not be a network with the Docker socket proxy. Only services which actually needs access to the Docker socket must be in such a network, in this case only Traefik.